Jump to content

Accordance Link Service Ignores URL Fragment


Steven S

Recommended Posts

The Accordance link service (https://accordance.bible/link/) appears to ignore the fragment component of the URL passed to it (i.e., everything after the hash [#]). For example, if I open

 

    https://accordance.bible/link/read/BDAG#20928

 

(which was generated by Accordance using the Copy As > Location URL command), the Accordance link service returns the following internal link:

 

    accord://read/BDAG

 

whereas I would expect it to return:

 

    accord://read/BDAG#20928

Link to comment
Share on other sites

I'll show this to our programmers. Thanks!

  • Like 1
Link to comment
Share on other sites

Possibly only tangentially related to the OP, but the following code on line 820:

 

window.setTimeout( () => window.location.replace( openInApp, 1000 ) )

 

looks like it's being executed immediately rather than after a delay of one second, which appears to be the original intent. I think it's supposed to be

 

window.setTimeout( () => window.location.replace( openInApp ), 1000 )

 

Link to comment
Share on other sites

@Nathan Parker, please disregard this bug report. The root cause is user error. :( I run NoScript in my browser and never whitelisted accordance.bible (only accordancebible.com). Once I did that, the URL is parsed correctly.

 

Apologies for the false alarm.

 

(But please note that my previous comment about the one second timeout still stands. If that was the original intent, it's not happening because the page redirects to the accord:// link immediately. But that's a much lower priority issue. :))

Link to comment
Share on other sites

No worries. I still sent the link to the programmers, so they can look at the timeout question.

  • Thanks 1
Link to comment
Share on other sites

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now
×
×
  • Create New...